Re: [PATCH] usbnet: add reset_resume quirk to prevent resume failure
From: David Miller <davem@davemloft.net>
Date: 2016-07-01 19:58:41
From: David Miller <davem@davemloft.net>
Date: 2016-07-01 19:58:41
From: Vivek Kumar Bhagat <redacted> Date: Thu, 30 Jun 2016 10:41:59 +0000 (GMT)
Ideally, usbnet_resume is sufficient for device resume operation. since usbcore function usb_resume_device() sets udev->reset_resume flag as a quirk solution, reset_resume() quirk we can keep in class driver also. We checked on dongle DA-Queen UFE20C, without reset function resume operation fails. Reason could be some power glitch during suspend time due to which device lose its internal state and it needs a device phy reset again during resume to recover. Signed-off-by: Vivek Kumar Bhagat <redacted> Signed-off-by: Vikas Bansal <redacted> Signed-off-by: Sangmin Bae <redacted>
You've seen this necessary for one device, yet you are doing this new reset for all usbnet devices. That doesn't sound correct or safe at all. I'm not applying this, sorry.