Thread (11 messages) 11 messages, 5 authors, 2016-06-28

Re: [PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage

From: Holger Schurig <hidden>
Date: 2016-06-28 07:37:00
Also in: linux-can, stable

static void can_dellink(struct net_device *dev, struct list_head *head);

and

static void can_dellink(struct net_device *dev, struct list_head *head)
{
	return;
}
Wouldn't the canonical form be this:

static void can_dellink(struct net_device *dev, struct list_head *head)
{
}


- the curly braces make sure this isn't a forward definition
- but no useless return either


But then again, this "return" is only cosmetical. No compiler will
generate any code from it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help