Thread (3 messages) 3 messages, 2 authors, 2016-06-30

RE: [PATCH v13 net-next 1/1] hv_sock: introduce Hyper-V Sockets

From: Dexuan Cui <decui@microsoft.com>
Date: 2016-06-30 14:33:34
Also in: lkml

From: David Miller [mailto:davem@davemloft.net]
Sent: Thursday, June 30, 2016 20:45
To: Dexuan Cui <decui@microsoft.com>
Cc: gregkh@linuxfoundation.org; netdev@vger.kernel.org; linux-
kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de;
apw@canonical.com; jasowang@redhat.com; vkuznets@redhat.com;
cavery@redhat.com; KY Srinivasan [off-list ref]; Haiyang Zhang
[off-list ref]; joe@perches.com; rolf.neugebauer@docker.com
Subject: Re: [PATCH v13 net-next 1/1] hv_sock: introduce Hyper-V Sockets

From: Dexuan Cui <decui@microsoft.com>
Date: Wed, 29 Jun 2016 11:30:40 +0000
quoted
@@ -1509,4 +1509,18 @@ static inline void commit_rd_index(struct
vmbus_channel *channel)
quoted
 }


+struct vmpipe_proto_header {
+	u32 pkt_type;
It is wasteful to have two empty lines before this structure definition, one
is sufficient.

...
Hi David,
Thank you for pointing out the issues!

I'll fix all of them, and check all the similar issues in the patch.

Will post a new version ASAP.

Thanks,
-- Dexuan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help