Thread (17 messages) 17 messages, 6 authors, 2016-06-30

Re: [PATCH net-next 9/9] net: hns: get reset registers from DT

From: Yankejian (Hackim Yim) <hidden>
Date: 2016-06-30 01:11:29
Also in: linux-arm-kernel, lkml

On 2016/6/29 17:11, David Miller wrote:
From: Yisen Zhuang <redacted>
Date: Mon, 27 Jun 2016 17:54:15 +0800
quoted
@@ -361,9 +371,10 @@ static int hns_mdio_reset(struct mii_bus *bus)
 			return -ENODEV;
 		}
 
+	sc_reg = &mdio_dev->sc_reg;
 		/* 1. reset req, and read reset st check */
-		ret = mdio_sc_cfg_reg_write(mdio_dev, MDIO_SC_RESET_REQ, 0x1,
-					    MDIO_SC_RESET_ST, 0x1,
+	ret = mdio_sc_cfg_reg_write(mdio_dev, sc_reg->mdio_reset_req, 0x1,
+				    sc_reg->mdio_reset_st, 0x1,
 					    MDIO_CHECK_SET_ST);
 		if (ret) {
 			dev_err(&bus->dev, "MDIO reset fail\n");
What in the world are you doing to the indentation here?

Please read your patches before actually sending them, such things
will be quite obvious by simple visual inspection.

.
Hi David,
i am sorry for my carelessness. i will pay more attention next time.
Thanks for pointing it our

-- 
MBR,
Yankejian (Hackim Yim)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help