Re: [PATCH] Maxim/driver: Add driver for maxim ds26522

From: Qiang Zhao <qiang.zhao@nxp.com>
Date: Fri, 24 Jun 2016 02:00:33 +0000

On Thu, 2016-06-23 at 10:59PM, David Miller wrote:

quoted

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Thursday, June 23, 2016 10:59 PM
To: Qiang Zhao <qiang.zhao@nxp.com>
Cc: oss@buserror.net; linux-kernel@vger.kernel.org; netdev@vger.kernel.org;
Xiaobo Xie [off-list ref]
Subject: Re: [PATCH] Maxim/driver: Add driver for maxim ds26522

From: Zhao Qiang <qiang.zhao@nxp.com>
Date: Thu, 23 Jun 2016 09:09:45 +0800

quoted

+MODULE_DESCRIPTION(DRV_DESC);

There is no definition of DRV_DESC, so this makes it look like you didn't even
compile this driver.

I really, really compiled this driver.
Thank you for your review and comments. I will modify it the next version.

[zhaoqiang@titan:~/upstream/linux]$ll drivers/net/wan/slic_ds26522.o
-rw-r--r-- 1 zhaoqiang klocwork 153288 Jun 22 15:48 drivers/net/wan/slic_ds26522.o
[zhaoqiang@titan:~/upstream/linux]$date

Obviously with the driver not configured as a module, and thus explicitly
not testing the failing statement at all.