Thread (8 messages) flat view 8 messages, 3 authors, 2016-06-14

Re: [V2, 4.8, 1/2] brcmutil: add field storing control channel to the struct brcmu_chan

From: Kalle Valo <hidden>
Date: 2016-06-14 14:28:23
Also in: linux-wireless, lkml

Rafał Miłecki wrote:
Our d11 code supports encoding/decoding channel info into/from chanspec
format used by firmware. Current implementation is quite misleading
because of the way "chnum" field is used.
When encoding channel info, "chnum" has to be filled by a caller with
*center* channel number. However when decoding chanspec the same field
is filled with a *control* channel number.

1) This can be confusing. It's expected for information to be the same
   after encoding and decoding.
2) It doesn't allow accessing all info when decoding. Some functions may
   need to know both channel numbers, e.g. cfg80211 callback getting
   current channel.
Solve this by adding a separated field for control channel.

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Thanks, 2 patches applied to wireless-drivers-next.git:

4712d88a5732 brcmutil: add field storing control channel to the struct brcmu_chan
ee6e7aa38394 brcmfmac: support get_channel cfg80211 callback

-- 
Sent by pwcli
https://patchwork.kernel.org/patch/9129323/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help