Thread (21 messages) 21 messages, 4 authors, 2016-06-07

Re: [PATCH 01/12] net: mediatek: fix DQL support

From: David Miller <davem@davemloft.net>
Date: 2016-06-07 23:01:19
Also in: linux-mediatek, lkml

From: John Crispin <john@phrozen.org>
Date: Mon, 6 Jun 2016 08:43:13 +0200
i think one solution would be to add some code to have 2 devices share
the same dql instance. would that be an acceptable solution ?
You still need to address the issue of synchronization.

dql purposefully doesn't use locking, always because a higher level
object (in this case the netdev TX queue) it is contained within
provides the synchronization.

That breaks apart once you share the dql between two netdevs, as you
are proposing here.  You'll have to add locking, which is expensive.

That's why I'm trying to encourage you to think out of the box and
find some way to solve the issue without having to access shared
state shared between multiple devices.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help