Thread (8 messages) flat view 8 messages, 3 authors, 2016-06-08

Re: [PATCH net] ethernet/sfc: report supported link speeds on SFP connections

From: Bert Kenward <hidden>
Date: 2016-06-06 15:16:03
Also in: lkml

Apologies for delay in replying.

On 03/06/16 02:33, Jarod Wilson wrote:
quoted hunk ↗ jump to hunk
My solarflare cards connected to a 10GbE switch with an SFP+ module/cable
don't currently report any supported link speeds:

...
diff --git a/drivers/net/ethernet/sfc/mcdi_port.c b/drivers/net/ethernet/sfc/mcdi_port.c
index 7f295c4..6516471 100644
--- a/drivers/net/ethernet/sfc/mcdi_port.c
+++ b/drivers/net/ethernet/sfc/mcdi_port.c
@@ -189,6 +189,10 @@ static u32 mcdi_to_ethtool_cap(u32 media, u32 cap)
 
 	case MC_CMD_MEDIA_XFP:
 	case MC_CMD_MEDIA_SFP_PLUS:
+		if (cap & (1 << MC_CMD_PHY_CAP_1000FDX_LBN))
+			result |= SUPPORTED_1000baseKX_Full;
+		if (cap & (1 << MC_CMD_PHY_CAP_10000FDX_LBN))
+			result |= SUPPORTED_10000baseKX4_Full;
We probably shouldn't be claiming KX/KX4 here, because it isn't. I'll post an
updated patch shortly.

Bert.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help