Re: [PATCH v2 5/7] net:mdio-mux: Add MDIO mux driver for iProc SoCs
flat view
From: David Miller <davem@davemloft.net>
Date: 2016-06-01 23:18:10
Also in:
linux-arm-kernel, linux-devicetree, lkml
From: Pramod Kumar <redacted> Date: Tue, 31 May 2016 19:06:39 +0530
quoted hunk ↗ jump to hunk
+static int iproc_mdio_wait_for_idle(void __iomem *base, bool result) +{ + u32 val; + unsigned int timeout = 1000; /* loop for 1s */
Please order your local variable declarations from longest to shortest line.
quoted hunk ↗ jump to hunk
+static int start_miim_ops(void __iomem *base, + u16 phyid, u32 reg, u16 val, u32 op) +{ + int ret; + u32 param;
Likewise.
quoted hunk ↗ jump to hunk
+static int iproc_mdiomux_read(struct mii_bus *bus, int phyid, int reg) +{ + int ret; + struct iproc_mdiomux_desc *md = bus->priv;
Likewise.