On Thu, Jun 30, 2016 at 4:11 PM, Daniel Borkmann [off-list ref] wrote:

On 07/01/2016 12:42 AM, Cong Wang wrote:

quoted

On Thu, Jun 30, 2016 at 12:50 PM, Daniel Borkmann [off-list ref]
wrote:

quoted

Maybe makes sense to move skb_push_rcsum() but /also/ skb_pull_rcsum()
to the header then? Both seem similarly small at least (could be split
f.e into two patches then, first for the move, second for the actual
fix).

No objection from me. Please feel free to send a patch. ;)

Shrug, I actually meant this as feedback to your patch, since you move that
helper and not as a note to myself. ;)

Interesting, my patch only moves what it needs, why does it need
to do more?

Again, I am not against your idea, just 1) it doesn't belong to my patch
2) I am too lazy to create a patch for it, or, I am perfectly fine with not
moving it too ;)