Re: [PATCH net] bonding: prevent out of bound accesses

From
Nikolay Aleksandrov <hidden>
Date
2016-06-30 13:25:03
Reply to
Eric Dumazet, 2016-06-30
On 30/06/16 14:56, Eric Dumazet wrote:
From: Eric Dumazet <redacted>

ether_addr_equal_64bits() requires some care about its arguments,
namely that 8 bytes might be read, even if last 2 byte values are not
used.

KASan detected a violation with null_mac_addr and lacpdu_mcast_addr
in bond_3ad.c

Fixes: 815117adaf5b ("bonding: use ether_addr_equal_unaligned for bond addr compare")
Fixes: bb54e58929f3 ("bonding: Verify RX LACPDU has proper dest mac-addr")
Signed-off-by: Eric Dumazet <redacted>
Reported-by: Dmitry Vyukov <dvyukov@google.com>
---
 drivers/net/bonding/bond_3ad.c |   11 +++++++----
 drivers/net/bonding/bond_alb.c |    3 ---
 include/net/bonding.h          |    7 ++++++-
 3 files changed, 13 insertions(+), 8 deletions(-)
Good catch,
Acked-by: Nikolay Aleksandrov <redacted>
Thread (12 messages) 12 messages, 5 authors, last reply 2016-07-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help