Re: [PATCH v2 net-next] tcp: md5: use kmalloc() backed scratch areas
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2016-06-29 15:04:09
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2016-06-29 15:04:09
On Wed, Jun 29, 2016 at 07:59:22AM -0700, Andy Lutomirski wrote:
quoted
I suspect that, if you compare a synchronous implementation that canuse virtual addresses to a DMA based implementation that can't, you'll find that, for short messages like tcp md5 uses, the synchronous implementation would win every time. I'm wondering if shash should gain the ability to use scatterlists and, if it doesn't already have it, the ability to use synchronous hardware implementations (like SHA-NI, for example, although I don't think that's useful for MD5).
I don't understand, if you add SGs to shash you get ahash. So why wouldn't you just use ahash? AFAICS tcp md5 already uses ahash in sync mode so there is nothing asynchronous here at all. Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt