Re: [PATCH net-next 03/16] net/mlx5: E-Switch, Add miss rule for offloads mode

On Mon, Jun 27, 2016 at 7:53 PM, Sergei Shtylyov
[off-list ref] wrote:

quoted

+static int esw_add_fdb_miss_rule(struct mlx5_eswitch *esw)
+{
+       struct mlx5_flow_destination dest;
+       struct mlx5_flow_rule *flow_rule = NULL;
+       int match_header = 0;

   This variable doesn't appear necessary...

yep

quoted

+       dest.type = MLX5_FLOW_DESTINATION_TYPE_VPORT;
+       dest.vport_num = 0;
+
+       flow_rule = mlx5_add_flow_rule(esw->fdb_table.fdb, match_header,
match_c,

   Why not just pass 0 instead of 'match_header'?

Correct, will fix that.