RE: [PATCH ethtool] ethtool.c: fix memory leaks

From: Ivan Vecera

Sent: 27 June 2016 10:41
On 26.6.2016 10:59, Ben Hutchings wrote:

quoted

On Fri, 2016-03-18 at 13:24 +0100, Ivan Vecera wrote:

quoted

Memory allocated at several places is not appropriately freed.

Given that ethtool is not a library or a long-running application - why
does that matter?

Ben.

Because each decently written program should clean up. Sure the kernel
will take care about it after exit but we cannot accept the fact that
short-running applications can behave like a pig.

It really doesn't matter except for memory that might be allocated
repeatedly.
The risks of getting it wrong probably outway any minor benefit.

free() is also unlikely to reduce the program size (to do so would require
a system call and TLB flush on top of everything else).

	David