Re: [PATCH net-next] ethtool: Macro definition for SFF-8436/8636 Memory map max sizes

On Sat, 2016-06-11 at 15:51 -0700, David Miller wrote:
[...]

Why do we need these values in the header file at all?

Because we don't like putting magic numbers in driver code, and these
sizes are defined by standards that are independent of a single driver.

The application can probe the size by repeated eeprom calls, increasing
the buffer size each time as needed until success.

But really it should use ETHTOOL_GMODULEINFO first.

Ben.

-- 
Ben Hutchings
The program is absolutely right; therefore, the computer must be wrong.