Re: [PATCHv2 net-next] sctp: sctp should change socket state when shutdown is received

Em 08-06-2016 07:42, Xin Long escreveu:

On Tue, Jun 7, 2016 at 7:03 PM, Xin Long [off-list ref] wrote:

quoted

On Sat, Jun 4, 2016 at 8:22 PM, Marcelo Ricardo Leitner

--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c

@@ -7565,10 +7565,12 @@ static void sctp_sock_migrate(struct sock

*oldsk, struct sock *newsk,
        /* If the association on the newsk is already closed before accept()
         * is called, set RCV_SHUTDOWN flag.
         */
-       if (sctp_state(assoc, CLOSED) && sctp_style(newsk, TCP))
+       if (sctp_state(assoc, CLOSED) && sctp_style(newsk, TCP)) {
+               newsk->sk_state = SCTP_SS_CLOSING;
                newsk->sk_shutdown |= RCV_SHUTDOWN;
+       } else
+               newsk->sk_state = SCTP_SS_ESTABLISHED;

-       newsk->sk_state = SCTP_SS_ESTABLISHED;

I'm still thinking about this, if we want to get addrs info from
closed assoc, like Adam's requirement. this will make it more
impossible.

case in
sctp_getsockopt_peer_addrs()->sctp_id2assoc():

                if (!sctp_sstate(sk, ESTABLISHED))
                        return NULL;

we can't  get assoc as sstate is SS_CLOSING already.

We probably can add another state to that if(). So far ESTABLISHED was 
the only reasonable state in there, but SS_CLOSING will make sense too 
then, I guess. A throughout check is necessary for this.

   Marcelo