Thread (22 messages) flat view 22 messages, 4 authors, 2016-06-08

Re: [PATCHv2 net 1/2] net: cls_u32: fix error code for invalid flags

From: John Fastabend <john.fastabend@gmail.com>
Date: 2016-06-07 15:47:50

On 16-06-07 03:46 AM, Jakub Kicinski wrote:
quoted hunk ↗ jump to hunk
'err' variable is not set in this test, we would return whatever
previous test set 'err' to.

Signed-off-by: Jakub Kicinski <redacted>
Reviewed-by: Dinan Gunawardena <redacted>
Reviewed-by: Simon Horman <redacted>
Acked-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
---
 net/sched/cls_u32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c
index 079b43b3c5d2..b17e090f2fe1 100644
--- a/net/sched/cls_u32.c
+++ b/net/sched/cls_u32.c
@@ -863,7 +863,7 @@ static int u32_change(struct net *net, struct sk_buff *in_skb,
 	if (tb[TCA_U32_FLAGS]) {
 		flags = nla_get_u32(tb[TCA_U32_FLAGS]);
 		if (!tc_flags_valid(flags))
-			return err;
+			return -EINVAL;
 	}
 
 	n = (struct tc_u_knode *)*arg;
Acking the v2 now -- seems nice to throw an error in this case.

Acked-by: John Fastabend <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help