Re: [PATCH net-next v10 2/5] openvswitch: set skb protocol and mac_len when receiving on internal device
From: pravin shelar <hidden>
Date: 2016-06-02 22:01:47
On Wed, Jun 1, 2016 at 11:24 PM, Simon Horman [off-list ref] wrote:
quoted hunk
* Set skb protocol based on contents of packet. I have observed this is necessary to get actual protocol of a packet when it is injected into an internal device e.g. by libnet in which case skb protocol will be set to ETH_ALL. * Set the mac_len which has been observed to not be set up correctly when an ARP packet is generated and sent via an openvswitch bridge. My test case is a scenario where there are two open vswtich bridges. One outputs to a tunnel port which egresses on the other. The motivation for this is that support for outputting to layer 3 (non-tap) GRE tunnels as implemented by a subsequent patch depends on protocol and mac_len being set correctly on receive. Signed-off-by: Simon Horman <redacted> --- v10 * Set mac_len v9 * New patch --- net/openvswitch/vport-internal_dev.c | 4 ++++ 1 file changed, 4 insertions(+)diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c index 2ee48e447b72..f89b1efa88f1 100644 --- a/net/openvswitch/vport-internal_dev.c +++ b/net/openvswitch/vport-internal_dev.c@@ -48,6 +48,10 @@ static int internal_dev_xmit(struct sk_buff *skb, struct net_device *netdev) { int len, err; + skb->protocol = eth_type_trans(skb, netdev); + skb_push(skb, ETH_HLEN); + skb_reset_mac_len(skb); +
resetting mac-len breaks the assumption about mac_len for referencing MPLS header ref: skb_mpls_header(). _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev