Thread (12 messages) flat view 12 messages, 5 authors, 2016-05-17

Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional

From: Andrew Lunn <andrew@lunn.ch>
Date: 2016-05-16 20:15:15
Also in: lkml

On Mon, May 16, 2016 at 08:52:43PM +0200, Alexander Graf wrote:
If you compile without OF_MDIO support in an RGMII configuration, we fail
to configure the dp83867 phy today by writing garbage into its configuration
registers.

On the other hand if you do compile with OF_MDIO and the phy gets loaded via
device tree, you have to have the properties set in the device tree, otherwise
we fail to load the driver and don't even attach the generic phy driver to
the interface anymore.

To make things slightly more consistent, make the rgmii configuration properties
optional and allow a user to omit them in their device tree.
The binding document actually says they are required. It would be good
to make the binding documentation and the code consistent.

   Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help