Thread (31 messages) flat view 31 messages, 2 authors, 2016-05-06

Re: [RFC PATCH net-next 19/20] net: dsa: mv88e6xxx: factorize tag protocol

From: Vivien Didelot <hidden>
Date: 2016-05-06 20:56:53
Also in: lkml

Hi Andrew,

Andrew Lunn [off-list ref] writes:
On Thu, May 05, 2016 at 06:41:03PM -0400, Vivien Didelot wrote:
quoted
6131 is the only driver to set the tag protocol to DSA_TAG_PROTO_DSA.
Since it works fine with DSA_TAG_PROTO_EDSA, change its value, like all
other mv88e6xxx drivers.
You might as well remove net/dsa/tag_dsa.c as well, since it is now
unused. Please do that as a separate patch.
Why not, but isn't it a bit out of the scope of this patchset?

Thanks,

        Vivien
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help