Re: [PATCH 3/3] net/mlx5e: don't build RFS without ethernet

On Wed, May 4, 2016 at 5:23 PM, Arnd Bergmann [off-list ref] wrote:

On Wednesday 04 May 2016 16:09:16 Saeed Mahameed wrote:

quoted

On Wed, May 4, 2016 at 3:32 PM, Arnd Bergmann [off-list ref] wrote:

quoted

The RFS acceleration support in mlx5 is enabled whenever CONFIG_RFS_ACCEL
is in use. However, this fails if a user turns off CONFIG_MLX5_CORE_EN,
because the rfs code now calls into the ethernet portion of the
driver:

ERROR: "mlx5e_destroy_flow_table" [drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko] undefined!

Hi Arnd,

We already posted a fix for this, please see "[PATCH net-next V1
01/12] net/mlx5e: Fix aRFS compilation dependency", and give us your
feedback.

That version looks fine as well. I think it's better to be a little
more explicit as I was, but either way seems fine.

Simply we didn't want to add new Kconfig flag.

You can also achieve the same thing in yet another way using Makefile
syntax instead of cpp or Kconfig:

ifdef CONFIG_MLX5_CORE_EN
mlx5_core-y += wq.o eswitch.o \
               en_main.o en_fs.o en_ethtool.o en_tx.o en_rx.o \
               en_txrx.o en_clock.o vxlan.o en_tc.o
               en_txrx.o en_clock.o vxlan.o en_tc.o en_arfs.o

mlx5_core-$(CONFIG_RFS_ACCEL) += en_arfs.o
endif


If you prefer Maor's version, feel free to add


Acked-by: Arnd Bergmann <redacted>

I do prefer this version, but the difference is small, so will keep Maor's.
Thanks Arnd for the Ack and the suggestion.

Saeed.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html