Re: [PATCH net-next v2] block/drbd: use nla_put_u64_64bit()
From: Nicolas Dichtel <hidden>
Date: 2016-05-04 12:49:08
Also in:
lkml
From: Nicolas Dichtel <hidden>
Date: 2016-05-04 12:49:08
Also in:
lkml
Le 04/05/2016 11:05, Lars Ellenberg a écrit : [snip]
We don't have an "alignment problem" there, btw. Last time I checked, we did work fine without this alignment magic, we already take care of that, yes, even on affected architectures.
The code adds several consecutive u64 attributes. The nl attribute header is 4 bytes, thus the full attribute length is 12 bytes. If the first u64 is aligned on 8 (nla_data()), the next one is not aligned on 8: it starts 12 bytes (8 (u64) + 4 (nl attr hdr)) after the previous u64.