Re: [PATCH net-next 1/4] scsi_tcp: block BH in TCP callbacks

On Wed, 2016-05-18 at 12:21 -0500, Mike Christie wrote:

Can I just confirm that nested bh lock calls like:

spin_lock_bh(lock1);
spin_lock_bh(lock2);

do something

spin_unlock_bh(lock2);
spin_unlock_bh(lock1);

is ok? It seems smatch sometimes warns about this.

It is ok.

More generally

local_bh_disable();
local_bh_disable();

..

local_bh_enable();
local_bh_enable();

is ok, we already have a lot of them.