Re: [patch net-next 0/4] return offloaded stats as default and expose original sw start

Thu, May 12, 2016 at 04:36:45PM CEST, andrew@lunn.ch wrote:

On Thu, May 12, 2016 at 11:59:54AM +0200, Jiri Pirko wrote:

quoted

From: Jiri Pirko <redacted>

Until now we had stats functions return SW statistics. However, it makes
a lot of sense to return HW stats as default.

Hi Jiri

DSA has always returned the HW stats, i.e, ethtool -S shows the
counters the switch has for the port.

How do you expect ethtool to handle your change? ethtool -S will print
both sets? Or are you thinking of adding a new flag?

Ethtool still continues to provide the hw counters. We do the same for
mlxsw driver. No change there.

I'm just trying to understand the big picture, and how it affects DSA,
if at all.

I didn't check the code, but if dsa provides sw stats by default, it
should be changed to provide hwstats instead. The goal is to keep the
existing applications to see what is going on.