Re: [PATCH net-next 1/2] net: l3mdev: Move get_saddr and rt6_dst From: David Miller <davem@davemloft.net> Date: 2016-05-07 19:01:19 From: David Ahern <redacted> Date: Wed, 4 May 2016 21:54:09 -0700 + if (dev && netif_is_l3_master(dev) && + dev->l3mdev_ops->l3mdev_get_saddr) { + rc = dev->l3mdev_ops->l3mdev_get_saddr(dev, fl4); + } Please do not use braces for single statement basic blocks. The same issue exists in patch #2 so please fix it there as well. Thanks.
Keyboard shortcuts hback out one level jnext message in thread kprevious message in thread ldrill in Escclose help / fold thread tree ?toggle this help