Thread (2 messages) 2 messages, 2 authors, 2016-05-03

Re: [PATCH net-next] net: relax expensive skb_unclone() in iptunnel_handle_offloads()

From: David Miller <davem@davemloft.net>
Date: 2016-05-03 04:23:29

From: Eric Dumazet <redacted>
Date: Sat, 30 Apr 2016 10:19:29 -0700
From: Eric Dumazet <edumazet@google.com>

Locally generated TCP GSO packets having to go through a GRE/SIT/IPIP
tunnel have to go through an expensive skb_unclone()

Reallocating skb->head is a lot of work.

Test should really check if a 'real clone' of the packet was done.

TCP does not care if the original gso_type is changed while the packet
travels in the stack.

This adds skb_header_unclone() which is a variant of skb_clone()
using skb_header_cloned() check instead of skb_cloned().

This variant can probably be used from other points.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Nice observation, applied, thanks Eric.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help