Re: [PATCH net] gre: do not pull header in ICMP error processing
From: David Miller <davem@davemloft.net>
Date: 2016-05-02 04:21:01
From: David Miller <davem@davemloft.net>
Date: 2016-05-02 04:21:01
From: Jiri Benc <redacted> Date: Fri, 29 Apr 2016 23:31:32 +0200
iptunnel_pull_header expects that IP header was already pulled; with this
expectation, it pulls the tunnel header. This is not true in gre_err.
Furthermore, ipv4_update_pmtu and ipv4_redirect expect that skb->data points
to the IP header.
We cannot pull the tunnel header in this path. It's just a matter of not
calling iptunnel_pull_header - we don't need any of its effects.
Fixes: bda7bb463436 ("gre: Allow multiple protocol listener for gre protocol.")
Signed-off-by: Jiri Benc <redacted>Applied and queued up for -stable, thanks Jiri.