Re: [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr on 64-bit

From
Balbir Singh <bsingharora@gmail.com>
Date
2016-04-27 12:29:38
Also in
lkml, netfilter-devel
Reply to
Nicolas Dichtel, 2016-04-27

On 27/04/16 17:29, Nicolas Dichtel wrote:
Le 27/04/2016 03:14, Balbir Singh a écrit :
quoted

On 23/04/16 01:31, Nicolas Dichtel wrote:
quoted
Goal of this patch is to use the new libnl API to align netlink attribute
when needed.
The layout of the netlink message will be a bit different after the patch,
because the padattr (TASKSTATS_TYPE_STATS) will be inside the nested
attribute instead of before it.

Signed-off-by: Nicolas Dichtel <redacted>
The layout will change/break user space -- I've not tested the patch though..
Sigh.

I quote David:
"All userspace components using netlink should always ignore attributes
they do not recognize in dumps.

This is one of the most basic principles of netlink"

Do you have some pointers so I can made some tests?
Please try

https://www.kernel.org/doc/Documentation/accounting/getdelays.c

iotop uses it as well. My concern is ABI breakage of user space.

Balbir Singh
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Thread (24 messages) 24 messages, 5 authors, last reply 2016-04-27
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help