Thread (4 messages) 4 messages, 3 authors, 2016-04-20

Re: [PATCH 2/5] arcnet: com90xx: add __init attribute

From: David Miller <davem@davemloft.net>
Date: 2016-04-20 00:18:08
Also in: kernel-janitors, lkml

From: Julia Lawall <redacted>
Date: Mon, 18 Apr 2016 16:55:35 +0200
Add __init attribute on a function that is only called from other __init
functions and that is not inlined, at least with gcc version 4.8.4 on an
x86 machine with allyesconfig.  Currently, the function is put in the
.text.unlikely segment.  Declaring it as __init will cause it to be put in
the .init.text and to disappear after initialization.

The result of objdump -x on the function before the change is as follows:

0000000000000000 l     F .text.unlikely 00000000000000bf check_mirror

And after the change it is as follows:

0000000000000000 l     F .init.text	00000000000000ba check_mirror

Done with the help of Coccinelle.  The semantic patch checks for local
static non-init functions that are called from an __init function and are
not called from any other function.

Signed-off-by: Julia Lawall <redacted>
Applied to net-next, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help