Re: [PATCH net-next 4/7] net: dsa: mv88e6xxx: add family to info

Vivien Didelot [off-list ref] writes:

quoted

quoted

+	{ MV88E6XXX_INFO(6165, 0x165, "Marvell 88E6165") },

I think 

quoted

+	{ MV88E6XXX_INFO(MV88E6XXX_FAMILY_6165, 0x165, "Marvell 88E6165") },

is clearer. It is hard to know what these values mean unless you go
look at the macro.

Same goes for the MV88E6XXX_INFO macro... I wanted to avoid long lines
while keeping the info table clear enough.

    MV88E6XXX_INFO(0x121, "Marvell 88E6123",
                   MV88E6XXX_FAMILY_6165,) },
   /*             Family   Prod   Name             */
   { MV88E6XXX_INFO(6165, 0x121, "Marvell 88E6123") },
   { MV88E6XXX_INFO(6165, 0x161, "Marvell 88E6161") },
   { MV88E6XXX_INFO(6165, 0x165, "Marvell 88E6165") },
   { MV88E6XXX_INFO(6165, 0x165, "Marvell 88E6165") },

But I don't really mind in fact, we'll do as you guys wish.

Oops, sent too fast. Thinking about that, I'll just keep plain struct
mv88e6xxx_info in the tables and we will maybe introduce such macro when
merging everything together.

Thanks,
Vivien