Re: [patch] tipc: remove an unnecessary NULL check
From: Xue, Ying <hidden>
Date: 2016-04-27 10:51:13
Also in:
kernel-janitors
From: Dan Carpenter [mailto:dan.carpenter@oracle.com] Sent: 2016年4月27日 16:05 To: Jon Maloy Cc: Xue, Ying; David S. Miller; netdev@vger.kernel.org; tipc- discussion@lists.sourceforge.net; kernel-janitors@vger.kernel.org Subject: [patch] tipc: remove an unnecessary NULL check This is never called with a NULL "buf" and anyway, we dereference 's' on the lines before so it would Oops before we reach the check. Signed-off-by: Dan Carpenter <redacted>
Acked-by: Ying Xue <redacted>
quoted hunk ↗ jump to hunk
diff --git a/net/tipc/subscr.c b/net/tipc/subscr.c index 79de588..0dd0224100644--- a/net/tipc/subscr.c +++ b/net/tipc/subscr.c@@ -326,8 +326,7 @@ static void tipc_subscrb_rcv_cb(struct net *net, intconid, return tipc_subscrp_cancel(s, subscriber); } - if (s) - tipc_subscrp_subscribe(net, s, subscriber, swap); + tipc_subscrp_subscribe(net, s, subscriber, swap); } /* Handle one request to establish a new subscriber */
------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ tipc-discussion mailing list tipc-discussion@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tipc-discussion