Thread (13 messages) 13 messages, 4 authors, 2016-04-13

Re: [RFC v5 0/5] Add virtio transport for AF_VSOCK

From: Stefan Hajnoczi <stefanha@redhat.com>
Date: 2016-04-13 13:38:44
Also in: kvm, virtualization

On Tue, Apr 12, 2016 at 05:37:54PM +0100, Ian Campbell wrote:
Perhaps the guest end is turning shutdown(foo) directly into a vsock
message without or-ing in the current state?
Yes, you are right:

  lock_sock(sk);
  sk->sk_shutdown |= mode;
  sk->sk_state_change(sk);
  release_sock(sk);

  if (sk->sk_type == SOCK_STREAM) {
      sock_reset_flag(sk, SOCK_DONE);
      vsock_send_shutdown(sk, mode);

Although sk_shutdown is ORed correctly, vsock_send_shutdown() is called with
just the shutdown() argument.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help