Thread (2 messages) flat view 2 messages, 2 authors, 2016-03-22

Re: [Y2038] [PATCH] prism54: isl_38xx: Replace 'struct timeval'

From: Arnd Bergmann <hidden>
Date: 2016-03-22 11:51:35
Also in: linux-wireless, lkml

On Tuesday 22 March 2016 02:55:22 Tina Ruchandani wrote:
Truly fixing this would 
require changing the debug print to print more than 8 digits and using 
a different specifier from %li.
Why not just change it to %lli, and a cast to s64? I don't think the
format string or the number of digits is important here because it's just
debug output that is normally disabled.

I also see an existing bug in the format string: "%08li.%08li" means we
end up printing a six digit microsecond value with two leading zeros,
which is rather confusing. I think using "%lld.%06ld" would be best
here, or possibly "%lld.%09ld" to print the whole nanoseconds so we
can skip the division.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help