Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB

Mason [off-list ref] writes:

On 18/03/2016 21:11, Uwe Kleine-König wrote:

quoted

Hello,

On Fri, Mar 18, 2016 at 08:31:20PM +0100, Mason wrote:

quoted

On 18/03/2016 20:12, Uwe Kleine-König wrote:

quoted

On Fri, Mar 18, 2016 at 04:56:21PM +0100, Sebastian Frias wrote:

quoted

What would you think of making at803x_link_change_notify() print a
message every time it should do a reset but does not has a way to do it?

Then this question is obsolete because the device doesn't probe.

I don't understand this statement.

What does it mean for a question to be obsolete?

If the driver doesn't probe because it cannot control the reset line,
you don't need to think about how it should behave in
at803x_link_change_notify without control of the reset line, because
this code isn't reached then.

If I understand correctly, it is possible to soft-reset the PHY
by writing to a specific register. The GPIO pin is useful only to
force a hardware-reset when the PHY is wedged by some random event.

Yes, and some variants of this phy are broken and require a hard reset
in certain situations.  At least that's what the comment in the code
says.

-- 
Måns Rullgård