Re: [PATCH v2 3/3] phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses.

Am 16.03.2016 um 23:54 schrieb David Daney:

On 03/16/2016 03:50 PM, Andreas Färber wrote:

quoted

Am 11.03.2016 um 18:53 schrieb David Daney:

quoted

diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index 40faec9..075a4cc 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig

@@ -196,6 +196,17 @@ config MDIO_OCTEON
        buses. It is required by the Octeon and ThunderX ethernet device
        drivers on some systems.

+config MDIO_THUNDER
+    tristate "Support for MDIO buses on on ThunderX SOCs"

Double "on", spotted in next-20160316.

quoted

+    depends on 64BIT
+    depends on PCI
+    select MDIO_CAVIUM
+    help
+      This driver supports the MDIO interfaces found on Cavium
+      ThunderX SoCs when the MDIO bus device appears on as a PCI
+      device.

While at it, this sentence sounds weird. Did you mean s/as/is/? Or is
there another verb missing in there?

Should be "... appears as a PCI device."

davem already merged the patch, so this would have to be fixed as a
follow-on patch.

Since you found this, do you want to send the patch?

Done.

Cheers,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)