Thread (1 message) 1 message, 1 author, 2016-03-06

Re: [PATCH RESEND] net:fec:Fix error checking in the function fec_enet_init

From: Uwe Kleine-König <hidden>
Date: 2016-03-06 11:10:11
Also in: lkml

Hello Nicholas,

On Fri, Mar 04, 2016 at 03:00:14PM -0500, Nicholas Krause wrote:
This fixes error checking in the function fec_enet_init to properly
check if the internal call to the function fec_enet_alloc_queue fails
and if so immediately return the error code to the caller for it to
handle it's own intended error paths.

Signed-off-by: Nicholas Krause <redacted>
Looks right. There seem to be some more oportunities for similar
patches. E.g. if dmam_alloc_coherent fails the effects of
fec_enet_alloc_queue should be undone.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help