Re: [PATCH] net: eth: altera: do not free array priv->mdio->irq
From: Andrew Lunn <andrew@lunn.ch>
Date: 2016-03-03 15:16:37
Also in:
lkml
On Thu, Mar 03, 2016 at 01:47:18PM +0000, Colin King wrote:
From: Colin Ian King <redacted>
priv->mdio->irq used to be allocated and required freeing, but it
is now a fixed sized array and should no longer be free'd.
Issue detected using static analysis with CoverityScan
Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
Signed-off-by: Colin Ian King <redacted>Reviewed-by: Andrew Lunn <andrew@lunn.ch> Thanks Andrew
quoted hunk ↗ jump to hunk
--- drivers/net/ethernet/altera/altera_tse_main.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c index 1747285..f749e4d 100644 --- a/drivers/net/ethernet/altera/altera_tse_main.c +++ b/drivers/net/ethernet/altera/altera_tse_main.c@@ -193,7 +193,6 @@ static void altera_tse_mdio_destroy(struct net_device *dev) priv->mdio->id); mdiobus_unregister(priv->mdio); - kfree(priv->mdio->irq); mdiobus_free(priv->mdio); priv->mdio = NULL; }-- 2.7.0