Re: [PATCH net] tun, bpf: fix suspicious RCU usage in tun_{attach,detach}_filter

[PATCH net] tun, bpf: fix suspicious RCU usage in tun_{attach,detach}_filter · Daniel Borkmann <daniel@iogearbox.net> · 2016-03-31
Re: [PATCH net] tun, bpf: fix suspicious RCU usage in tun_{attach,detach}_filter · Alexei Starovoitov <hidden> · 2016-03-31
Re: [PATCH net] tun, bpf: fix suspicious RCU usage in tun_{attach,detach}_filter · Michal Kubecek <hidden> · 2016-03-31
Re: [PATCH net] tun, bpf: fix suspicious RCU usage in tun_{attach,detach}_filter · Alexei Starovoitov <hidden> · 2016-03-31
Re: [PATCH net] tun, bpf: fix suspicious RCU usage in tun_{attach,detach}_filter · Michal Kubecek <hidden> · 2016-03-31
Re: [PATCH net] tun, bpf: fix suspicious RCU usage in tun_{attach,detach}_filter · Alexei Starovoitov <hidden> · 2016-03-31
Re: [PATCH net] tun, bpf: fix suspicious RCU usage in tun_{attach,detach}_filter · Daniel Borkmann <daniel@iogearbox.net> · 2016-03-31
Re: [PATCH net] tun, bpf: fix suspicious RCU usage in tun_{attach,detach}_filter · Eric Dumazet <hidden> · 2016-03-31
Re: [PATCH net] tun, bpf: fix suspicious RCU usage in tun_{attach,detach}_filter · Daniel Borkmann <daniel@iogearbox.net> · 2016-03-31
Re: [PATCH net] tun, bpf: fix suspicious RCU usage in tun_{attach,detach}_filter · David Miller <davem@davemloft.net> · 2016-03-31
Re: [PATCH net] tun, bpf: fix suspicious RCU usage in tun_{attach,detach}_filter · Hannes Frederic Sowa <hidden> · 2016-03-31
Re: [PATCH net] tun, bpf: fix suspicious RCU usage in tun_{attach,detach}_filter · Alexei Starovoitov <hidden> · 2016-03-31
Re: [PATCH net] tun, bpf: fix suspicious RCU usage in tun_{attach,detach}_filter · David Miller <davem@davemloft.net> · 2016-03-31
Re: [PATCH net] tun, bpf: fix suspicious RCU usage in tun_{attach,detach}_filter · David Miller <davem@davemloft.net> · 2016-03-31
Re: [PATCH net] tun, bpf: fix suspicious RCU usage in tun_{attach,detach}_filter · Hannes Frederic Sowa <hidden> · 2016-03-31
Re: [PATCH net] tun, bpf: fix suspicious RCU usage in tun_{attach,detach}_filter · David Miller <davem@davemloft.net> · 2016-03-31
Re: [PATCH net] tun, bpf: fix suspicious RCU usage in tun_{attach,detach}_filter · Daniel Borkmann <daniel@iogearbox.net> · 2016-03-31
Re: [PATCH net] tun, bpf: fix suspicious RCU usage in tun_{attach,detach}_filter · Hannes Frederic Sowa <hidden> · 2016-03-31
Re: [PATCH net] tun, bpf: fix suspicious RCU usage in tun_{attach,detach}_filter · Hannes Frederic Sowa <hidden> · 2016-03-31
Re: [PATCH net] tun, bpf: fix suspicious RCU usage in tun_{attach,detach}_filter · Jiri Slaby <hidden> · 2016-03-31

From: David Miller <davem@davemloft.net>
Date: 2016-03-31 19:50:34

From: Hannes Frederic Sowa <redacted>
Date: Thu, 31 Mar 2016 21:48:27 +0200

Tightest solution would probably be to combine both patches.

bool called_by_tuntap;

old_fp = rcu_dereference_protected(sk->sk_filter, called_by_tuntap ?
lockdep_rtnl_is_held() : lockdep_sock_is_held());

Ok, I see what you're saying.

I misunderstood how the RTNL lockdep checks work and thought we could
get false positives from other entities taking RTNL.

Can you cook up the combined patch?

Thanks.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help