Re: [PATCH net-next v3 1/2] RDS: TCP: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket

On 3/15/2016 11:53 AM, Sowmini Varadhan wrote:

Add per-net sysctl tunables to set the size of sndbuf and
rcvbuf on the kernel tcp socket.

The tunables are added at /proc/sys/net/rds/tcp/rds_tcp_sndbuf
and /proc/sys/net/rds/tcp/rds_tcp_rcvbuf.

Since these values must be set before accept() or connect(),
and there may be an arbitrary number of existing rds-tcp
sockets when the tunable is modified. To make sure that all
connections in the netns pick up the same value for the tunable,
we reset existing rds-tcp connections in the netns, so that
they can reconnect with the new parameters.

Signed-off-by: Sowmini Varadhan <redacted>
---
v2; use sysctl instead of module param. Tunabes are now per netns,
     and can be dynamically modified without restarting all namespaces.
v3: review comments from Santosh Shilimkar,  Eric Dumazet

  net/rds/tcp.c |  143 +++++++++++++++++++++++++++++++++++++++++++++++++++++----
  1 files changed, 134 insertions(+), 9 deletions(-)

This version looks fine to me. Thanks !!

Acked-by: Santosh Shilimkar <redacted>