Re: [PATCH/RFC v6 net-next] ravb: Add dma queue interrupt support

From
Yoshihiro Kaneko <hidden>
Date
2016-03-07 16:27:28
Also in
linux-sh
Reply to
Sergei Shtylyov, 2016-03-02
2016-03-03 3:50 GMT+09:00 Sergei Shtylyov [off-list ref]:
On 03/02/2016 09:16 PM, Yoshihiro Kaneko wrote:
quoted
quoted
quoted
From: Kazuya Mizuguchi <redacted>

This patch supports the following interrupts.

- One interrupt for multiple (timestamp, error, gPTP)
- One interrupt for emac
- Four interrupts for dma queue (best effort rx/tx, network control
rx/tx)

This patch improve efficiency of the interrupt handler by adding the
interrupt handler corresponding to each interrupt source described
above. Additionally, it reduces the number of times of the access to
EthernetAVB IF.
Also this patch prevent this driver depends on the whim of a boot
loader.

[ykaneko0929@gmail.com: define bit names of registers]
[ykaneko0929@gmail.com: add comment for gen3 only registers]
[ykaneko0929@gmail.com: fix coding style]
[ykaneko0929@gmail.com: update changelog]
[ykaneko0929@gmail.com: gen3: fix initialization of interrupts]
[ykaneko0929@gmail.com: gen3: fix clearing interrupts]
[ykaneko0929@gmail.com: gen3: add helper function for request_irq()]
[ykaneko0929@gmail.com: gen3: remove IRQF_SHARED flag for request_irq()]
[ykaneko0929@gmail.com: revert ravb_close() and ravb_ptp_stop()]
[ykaneko0929@gmail.com: avoid calling free_irq() to non-hooked
interrupts]
[ykaneko0929@gmail.com: make NC/BE interrupt handler a function]
[ykaneko0929@gmail.com: make timestamp interrupt handler a function]
[ykaneko0929@gmail.com: timestamp interrupt is handled in multiple
   interrupt handler instead of dma queue interrupt handler]
Signed-off-by: Kazuya Mizuguchi <redacted>
Signed-off-by: Yoshihiro Kaneko <redacted>

    OK, you are very close now! Just a few comments...
[...]
quoted
quoted
quoted
diff --git a/drivers/net/ethernet/renesas/ravb_main.c
b/drivers/net/ethernet/renesas/ravb_main.c
index c936682..22ef65d 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
[...]
quoted
quoted
quoted

+static irqreturn_t ravb_rx_tx_interrupt(int irq, void *dev_id, int
ravb_queue)

   Please, please shorten this 'ravb_queue'...

I will fix it.
quoted
    Also, would make sense to rename it to ravb_dma_interrupt()...

I have renamed it from ravb_dmaq_interrupt() in this version as you
suggested in the previous review. Did you not mean it?

   Yes, I meant that, though perhaps got somewhat muddled up. Another
variant is to call the current ravb_queue_interrupt()
ravb_dma_interrupt_unlocked() (after adding the register reads there)
calling this one ravb_dma_interrupt() but I don't insist on the former,
ravb_queue_interrupt() is good enough as is; just rename this function
please.
Thanks for the clarification. I understand.
I will rename this function to ravb_dma_interrupt().
quoted
quoted
[...]

    Unfortunately, I still can't do a full gen2 regression testing as
both
Alt and Porter boards don't work with the recent kernel due to AVB_MDIO
stuck at 1... But perhaps such testing isn't even necessary.

Thanks,
kaneko

MBR, Sergei
Thanks,
kaneko
Thread (6 messages) 6 messages, 2 authors, last reply 2016-03-08
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help