Re: [ethtool PATCH v3 10/12] internal.h: TRUE/FALSE macros
From: Ben Hutchings <hidden>
Date: 2016-03-07 16:12:23
On Fri, 2016-03-04 at 16:42 -0800, David Decotigny wrote:
quoted hunk ↗ jump to hunk
From: David Decotigny <redacted> Signed-off-by: David Decotigny <redacted> --- internal.h | 8 ++++++++ 1 file changed, 8 insertions(+)diff --git a/internal.h b/internal.h index 5df8124..7c44d0e 100644 --- a/internal.h +++ b/internal.h@@ -42,6 +42,14 @@ typedef int32_t s32;#include "ethtool-copy.h" #include "net_tstamp-copy.h" +#ifndef TRUE +# define TRUE 1 +#endif + +#ifndef FALSE +# define FALSE 0 +#endif
I'd much prefer true and false as defined in <stdbool.h>. Ben.
#if __BYTE_ORDER == __BIG_ENDIAN
static inline u16 cpu_to_be16(u16 value)
{-- Ben Hutchings The most exhausting thing in life is being insincere. - Anne Morrow Lindberg
Attachments
- signature.asc [application/pgp-signature] 819 bytes