[ethtool PATCH v2 02/12] ethtool.c: don't ignore fread() return value
flat view
STALE3872d
From: David Decotigny <hidden>
Date: 2016-03-04 04:23:42
Subsystem:
the rest · Maintainer:
Linus Torvalds
Revision v2 of 10 in this series.
Revisions (10)
From: David Decotigny <redacted> This addresses: ethtool.c:1116:8: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result [-Wunused-result] Signed-off-by: David Decotigny <redacted> --- ethtool.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/ethtool.c b/ethtool.c
index 92c40b8..8a93dd1 100644
--- a/ethtool.c
+++ b/ethtool.c@@ -1007,6 +1007,7 @@ static int dump_regs(int gregs_dump_raw, int gregs_dump_hex, if (gregs_dump_file) { FILE *f = fopen(gregs_dump_file, "r"); struct stat st; + size_t nread; if (!f || fstat(fileno(f), &st) < 0) { fprintf(stderr, "Can't open '%s': %s\n",
@@ -1016,8 +1017,10 @@ static int dump_regs(int gregs_dump_raw, int gregs_dump_hex, regs = realloc(regs, sizeof(*regs) + st.st_size); regs->len = st.st_size; - fread(regs->data, regs->len, 1, f); + nread = fread(regs->data, regs->len, 1, f); fclose(f); + if (1 != nread) + return -1; } if (!gregs_dump_hex)
--
2.7.0.rc3.207.g0ac5344