Re: [PATCH net] vxlan: fix missing options_len update on RX with collect metadata
flat view
From: David Miller <davem@davemloft.net>
Date: 2016-03-03 22:11:16
From: Daniel Borkmann <daniel@iogearbox.net> Date: Wed, 2 Mar 2016 02:32:08 +0100
When signalling to metadata consumers that the metadata_dst entry
carries additional GBP extension data for vxlan (TUNNEL_VXLAN_OPT),
the dst's vxlan_metadata information is populated, but options_len
is left to zero. F.e. in ovs, ovs_flow_key_extract() checks for
options_len before extracting the data through ip_tunnel_info_opts_get().
Geneve uses ip_tunnel_info_opts_set() helper in receive path, which
sets options_len internally, vxlan however uses ip_tunnel_info_opts(),
so when filling vxlan_metadata, we do need to update options_len.
Fixes: 4c22279848c5 ("ip-tunnel: Use API to access tunnel metadata options.")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>Applied and queued up for -stable, thanks Daniel.