Re: [net-next PATCH] net: relax setup_tc ndo op handle restriction
From: David Miller <davem@davemloft.net>
Date: 2016-03-03 21:25:48
Also in:
intel-wired-lan
From: David Miller <davem@davemloft.net>
Date: 2016-03-03 21:25:48
Also in:
intel-wired-lan
From: John Fastabend <john.fastabend@gmail.com> Date: Mon, 29 Feb 2016 11:26:13 -0800
I added this check in setup_tc to multiple drivers,
if (handle != TC_H_ROOT || tc->type != TC_SETUP_MQPRIO)
Unfortunately restricting to TC_H_ROOT like this breaks the old
instantiation of mqprio to setup a hardware qdisc. This patch
relaxes the test to only check the type to make it equivalent
to the check before I broke it. With this the old instantiation
continues to work.
A good smoke test is to setup mqprio with,
# tc qdisc add dev eth4 root mqprio num_tc 8 \
map 0 1 2 3 4 5 6 7 \
queues 0@0 1@1 2@2 3@3 4@4 5@5 6@6 7@7
Fixes: e4c6734eaab9 ("net: rework ndo tc op to consume additional qdisc handle paramete")
Reported-by: Singh Krishneil <redacted>
Reported-by: Jake Keller <jacob.e.keller@intel.com>...
Signed-off-by: John Fastabend <redacted>
Applied, thanks John.