Re: [PATCH] drivers: net: cpsw-phy-sel: add dev_warn() for unsupported PHY mode
From: Mugunthan V N <hidden>
Date: 2016-02-15 06:15:59
Also in:
linux-arm-kernel, linux-omap
From: Mugunthan V N <hidden>
Date: 2016-02-15 06:15:59
Also in:
linux-arm-kernel, linux-omap
On Saturday 13 February 2016 06:15 AM, David Rivshin (Allworx) wrote:
From: David Rivshin <redacted> The cpsw-phy-sel driver supports only MII, RMII, and RGMII PHY modes, and silently handled any other values as if MII was specified. In a case where the PHY mode was incorrectly specified, or a bug elsewhere, there would be no indication of a problem. If MII was the correct mode, then this will go unnoticed, otherwise the symptom will be a failure to transmit/receive data over the RMII/RGMII link. Add a dev_warn() to make this condition obvious and provide a breadcrumb to follow. Cc: Mugunthan V N <redacted> Signed-off-by: David Rivshin <redacted>
Acked-by: Mugunthan V N <redacted> Regards Mugunthan V N