Re: [PATCH 3/3] 3c59x: Use setup_timer()

On Sun, Feb 28, 2016 at 12:18 AM, Stafford Horne [off-list ref] wrote:

On Thu, 25 Feb 2016, David Miller wrote:

quoted

From: Amitoj Kaur Chawla <redacted>
Date: Wed, 24 Feb 2016 19:28:19 +0530

quoted

Convert a call to init_timer and accompanying intializations of
the timer's data and function fields to a call to setup_timer.

The Coccinelle semantic patch that fixes this problem is
as follows:

// <smpl>
@@
expression t,f,d;
@@

-init_timer(&t);
+setup_timer(&t,f,d);
 ...
-t.data = d;
-t.function = f;
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <redacted>

Applied.

Hi David, Amitoj,

The patch here seemed to remove the call to add_timer(&vp->timer) which
applies the expires time. Would that be an issue?

-Stafford

I'm sorry. This is my mistake. How can I rectify it now that the patch
is applied?

Should I send a patch adding it back?

Amitoj