Re: [PATCH V2 03/12] net-next: mediatek: add embedded switch driver (ESW)
From: Andrew Lunn <andrew@lunn.ch>
Date: 2016-02-26 17:05:52
Also in:
linux-arm-kernel, linux-mediatek, lkml
From: Andrew Lunn <andrew@lunn.ch>
Date: 2016-02-26 17:05:52
Also in:
linux-arm-kernel, linux-mediatek, lkml
the problem here is that on one side people complain about vendors not sending code upstream. once they start being a good citizen and provide funding to send stuff upstream the feedback tends to be very bad as seen here. we are planning on doing a DSA driver but one step at a time. this kind of feedback will inevitably lead to vendors doing second thoughts of upstream contributions.
I think it is great a vendor is providing funding to get code upstream. However, that code needs to conform with current kernel architecture and design philosophy. We as a community also need to be consistent. We have recently push back on Microchip with there LAN9352 who want to do something very similar, introduce the MAC and a very dumb switch driver. They are now looking at what it means to do a DSA driver. There is also talk of writing a DSA driver for the ks8995 family. As David said recently, a year ago this probably would of been accepted. But now, switches need to be DSA or switchdev. Andrew