Thread (17 messages) flat view 17 messages, 4 authors, 2016-02-24

Re: [PATCH v8 5/8] time: Add history to cross timestamp interface supporting slower devices

From: Thomas Gleixner <hidden>
Date: 2016-02-24 10:58:16
Also in: intel-wired-lan, lkml

On Mon, 22 Feb 2016, Christopher S. Hall wrote:
+{
+	struct timekeeper *tk = &tk_core.timekeeper;
+	bool interp_forward;
+	u64 corr_raw, corr_real;
+	int ret;
Once more:

	struct timekeeper *tk = &tk_core.timekeeper;
	u64 corr_raw, corr_real;
	bool interp_forward;
	int ret;

Is way simpler to parse fast.
quoted hunk ↗ jump to hunk
 {
 	struct timekeeper *tk = &tk_core.timekeeper;
@@ -929,6 +1046,12 @@ int get_device_system_crosststamp(int (*get_time_fn)
 	ktime_t base_real;
 	s64 nsec_raw;
 	s64 nsec_real;
+	cycles_t cycles;
+	cycle_t now;
+	cycle_t interval_start;
+	unsigned int clock_was_set_seq;
+	u8 cs_was_changed_seq;
+	bool do_interp;
Single lines for same types .....

Other than that:

Reviewed-by: Thomas Gleixner <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help