Re: [PATCH] net: jme: fix suspend/resume on JMC260

On Tue, Feb 23, 2016 at 2:11 AM, Diego Viola [off-list ref] wrote:

On Tue, Feb 23, 2016 at 1:42 AM, David Miller [off-list ref] wrote:

quoted

From: Diego Viola <redacted>
Date: Mon, 22 Feb 2016 22:58:48 -0300

quoted

On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam [off-list ref] wrote:

quoted

On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola [off-list ref] wrote:

quoted

Signed-off-by: Diego Viola <redacted>

You should write a commit log.

I thought about including the link to my bug report:
https://bugzilla.kernel.org/show_bug.cgi?id=112351

What else would you suggest I add to the commit message?

The commit message is where you describe the change you are making.

This includes exactly what you are fixing, how you are doing it, and why
you are doing it that way.

Empty commit log messages are %99.99999 of the time completely
inappropriate.

David,

I understand and appreciate your advice, thanks.

However, please consider that I'm not a kernel developer, so I don't
understand much or anything about how this driver works internally,
this is why I came here to report about problem in the first place.

All I can tell you for certain is that this change makes my
suspend/resume work and it doesn't hang anymore while resuming from
suspend.

I apologize for the empty commit message and for not being able to
explain things deeper, but Pavel Machek is the person who suggested I
make this change in the code, so maybe he can provide some help?

Diego

I will try sending a V2 patch again with a proper commit message, sorry.

Diego