Re: [PATCH] dmascc: Return correct error codes
From: David Miller <davem@davemloft.net>
Date: 2016-02-16 20:33:06
Also in:
linux-hams, lkml
From: David Miller <davem@davemloft.net>
Date: 2016-02-16 20:33:06
Also in:
linux-hams, lkml
From: Amitoj Kaur Chawla <redacted> Date: Wed, 10 Feb 2016 00:12:36 +0530
This change has been made with the goal that kernel functions should return something more descriptive than -1 on failure. A variable `err` has been introduced for storing error codes. The return value of kzalloc on failure should return a -1 and not a -ENOMEM. This was found using Coccinelle. A simplified version of the semantic patch used is:
...
Furthermore, set `err` to -ENOMEM on failure of alloc_netdev(), and to -ENODEV on failure of register_netdev() and probe_irq_off(). The single call site only checks that the return value is not 0, hence no change is required at the call site. Signed-off-by: Amitoj Kaur Chawla <redacted>
Applied to net-next, thanks.